linux-kernel - Re: [RFC] x86, fpu: unify signal handling code paths for x86 and x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120614143727.GF7922@escobedo.osrc.amd.com>
Date:	Thu, 14 Jun 2012 16:37:28 +0200
From:	Hans Rosenfeld <hans.rosenfeld@....com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
CC:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	<tglx@...utronix.de>, <robert.richter@....com>,
	<andreas.herrmann3@....com>
Subject: Re: [RFC] x86, fpu: unify signal handling code paths for x86 and
 x86_64 kernels

Hi Suresh,

On Tue, Jun 12, 2012 at 05:03:34PM -0700, Suresh Siddha wrote:
> I can split the patch if needed. And I need to do little bit more
> validation (already tested on 64-bit IVB  and 32-bit NHM) before
> removing the 'RFC' tag.
> 
> I tried starting with the old version of Hans patch. But there were lot
> more changes in this area since then and also his patch had few
> user-visible compatibility issues.
> 
> Appended is the version that I came up with. Please review.

Thank you for working on this.

I didn't see anything obviously wrong in a quick review of this code,
but this stuff is too complex for this to mean anything :)

I ran a quick test of your code. I found a signal frame corruption when
running a 32bit test program on a 64bit kernel. I didn't try to find out
why it failed, but I'll send you the test program in a private mail so
you can look at it yourself.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/