[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADTbHxpfQpKMkwzUakUUzt1mKO5rQ2A7_vuh9SA7i6Cq0VinZg@mail.gmail.com>
Date: Sat, 16 Jun 2012 00:20:04 +0530
From: Pankaj Jangra <jangra.pankaj9@...il.com>
To: Philip Rakity <philipspatches@...il.com>
Cc: linux-kernel@...r.kernel.org, broonie@...nsource.wolfsonmicro.com,
linux-mmc@...r.kernel.org, Philip Rakity <prakity@...vell.com>
Subject: Re: [PATCH 1/2] regulator: core.c Pass voltage to notifier when
setting voltage
Hi,
On Fri, Jun 15, 2012 at 11:57 PM, Philip Rakity
<philipspatches@...il.com> wrote:
> V3
> --
>
> Fix type where data argument was not passed in
> blocking_notifier_call_chain.
>
> edits to check in comments (below)
>
> V2
> --
>
> Incorporate performance suggestions made by Mark Brown
> Use linux-next as base code rather than mmc-next
>
> The voltage being set should be passed to the call in handler
> requesting the callback. Currently this is not done.
>
> The callin handler cannot call regulator_get_voltage() to get the
"The calling"
> information since the mutex is held by the regulator and
> deadlock occurs.
>
> Without this change the receiver of the call in cannot know what
> action to take. This is used, for example, to set PAD voltages
> when doing SD vccq voltage changes.
>
> Signed-off-by: Philip Rakity <prakity@...vell.com>
> ---
Since you are submitting your patch from the different email than your
Singed-off email. So you should put in first line of message
From: <your real email>.
Regards,
Pankaj Jangra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists