linux-kernel - Re: [PATCH 6/7] regualtor: Add samsung s2mps11 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2012 13:50:05 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sangbeom Kim <sbkim73@...sung.com>
Cc:	sameo@...ux.intel.com, 'Liam Girdwood' <lrg@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] regualtor: Add samsung s2mps11 regulator driver

On Mon, Jun 18, 2012 at 08:29:41PM +0900, Sangbeom Kim wrote:

> +static int s2mps11_list_voltage(struct regulator_dev *rdev,
> +				unsigned int selector)
> +{

Please take a look at the new helper functions which have been added to
the regulator core for factoring out things like table based and linear
maps.  This and quite a bit of the rest of the code can probably be
converted to use those.

> +	case S2MPS11_AP_EN32KHZ:
> +		mask = 0x01;
> +		break;
> +	case S2MPS11_CP_EN32KHZ:
> +		mask = 0x02;
> +		break;
> +	case S2MPS11_BT_EN32KHZ:
> +		mask = 0x04;
> +		break;

Use the clk API for clocks.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)