linux-kernel - Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618125232.GO3974@opensource.wolfsonmicro.com>
Date:	Mon, 18 Jun 2012 13:52:32 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Sangbeom Kim <sbkim73@...sung.com>
Cc:	sameo@...ux.intel.com, 'Liam Girdwood' <lrg@...com>,
	linux-kernel@...r.kernel.org, sbkim01@...il.com
Subject: Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic

On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote:

> -struct sec_irq_data {
> -	int reg;
> -	int mask;
> +static struct sec_irq_data s2mps11_irqs[] = {
> +	[S2MPS11_IRQ_PWRONF] = {
> +		.reg = 1,
> +		.mask = S2MPS11_IRQ_PWRONF_MASK,
> +	},

This looks like you should be able to factor this code out into
regmap_irq?  Might be worth doing that first before all the renames so
that adding the new PMIC would just be adding some more data.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)