linux-kernel - Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120702143343.GG22065@sortiz-mobl>
Date:	Mon, 2 Jul 2012 16:33:43 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Sangbeom Kim <sbkim73@...sung.com>
Cc:	'Liam Girdwood' <lrg@...com>, linux-kernel@...r.kernel.org,
	sbkim01@...il.com
Subject: Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic

Hi Sangbeom,

On Mon, Jun 18, 2012 at 01:52:32PM +0100, Mark Brown wrote:
> On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote:
> 
> > -struct sec_irq_data {
> > -	int reg;
> > -	int mask;
> > +static struct sec_irq_data s2mps11_irqs[] = {
> > +	[S2MPS11_IRQ_PWRONF] = {
> > +		.reg = 1,
> > +		.mask = S2MPS11_IRQ_PWRONF_MASK,
> > +	},
> 
> This looks like you should be able to factor this code out into
> regmap_irq?  Might be worth doing that first before all the renames so
> that adding the new PMIC would just be adding some more data.
Would you mind looking into that ? I'm ok with the renaming parts of this
patchset, but I think addressing Mark comment here would make the last patch
look better (and smaller).

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/