linux-kernel - Re: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618150434.GL4400@mwanda>
Date:	Mon, 18 Jun 2012 18:04:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Miguel Gómez <magomez@...lia.com>
Cc:	arnaud.patard@...-net.org, gregkh@...uxfoundation.org,
	aaro.koskinen@....fi, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.

On Mon, Jun 18, 2012 at 01:12:03PM +0200, Miguel Gómez wrote:
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1376,8 +1376,10 @@ static int XGIfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
>  		vtotal = var->upper_margin + var->yres + var->lower_margin
>  				+ var->vsync_len;
>  
> -	if (!(htotal) || !(vtotal))
> -		XGIFAIL("XGIfb: no valid timing data");
> +	if (!(htotal) || !(vtotal)) {

Don't resend this, but next time feel free to write this like:

	if (!htotal || !vtotal) {

We do have a one change per patch rule but tiny formatting things
like that don't count as a change.

regards,
dan carpenter

> +		pr_debug("XGIfb: no valid timing data\n");
> +		return -EINVAL;
> +	}
>  
>  	if (var->pixclock && htotal && vtotal) {
>  		drate = 1000000000 / var->pixclock;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/