linux-kernel - Re: [PATCH 3/8] Staging: xgifb: remove DPRINTK() macro and replace it with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120618145934.GK4400@mwanda>
Date:	Mon, 18 Jun 2012 17:59:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Miguel Gómez <magomez@...lia.com>
Cc:	arnaud.patard@...-net.org, gregkh@...uxfoundation.org,
	aaro.koskinen@....fi, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] Staging: xgifb: remove DPRINTK() macro and replace
 it with pr_debug.

On Mon, Jun 18, 2012 at 01:12:01PM +0200, Miguel Gómez wrote:
>  			} else if (XGIfb_vrate[i].refresh > rate) {
>  				if ((XGIfb_vrate[i].refresh - rate) <= 3) {
> -					DPRINTK("XGIfb: Adjusting rate from %d up to %d\n",
> -						rate, XGIfb_vrate[i].refresh);
> +					pr_debug("XGIfb: Adjusting rate from %d up to %d\n",
> +						 rate, XGIfb_vrate[i].refresh);

This file already has a pr_fmt set so if you wanted, you could just
remove the "XGIfb: ".  This was already there in the original code
so don't resend.  But if you want to send another patch which
removes them that would be grand.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/