[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FDFA760.5040403@intel.com>
Date: Mon, 18 Jun 2012 19:10:40 -0300
From: Eugeni Dodonov <eugeni.dodonov@...el.com>
To: Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
CC: Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
stable@...r.kernel.org, torvalds@...ux-foundation.org,
akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
Daniel Vetter <daniel.vetter@...ll.ch>,
Chris Wilson <chris@...is-wilson.co.uk>
Subject: Re: [ 04/69] drm/i915: fix up ivb plane 3 pageflips
On 06/18/2012 06:55 PM, Herton Ronaldo Krzesinski wrote:
>> + default:
>> + WARN_ONCE(1, "unknown plane in flip command\n");
>> + ret = -ENODEV;
>> + goto err;
>
> Shouldn't this have been "goto err_unpin;"?
>
> It's not a problem in the backport for 3.2, same code is in the original
> patch, just noticed it seems a problem while looking at it; but by what
> changelog says the default case is said to not trigger in "practice"
> (catch programming error), so I think it doesn't pose a real issue in
> practice.
You are right, it should be err_unpin. I sent a patch rectifying this.
In practice, this should not happen, but still, better be safe than
sorry. Thanks for catching that!
Eugeni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists