linux-kernel - RE: [ 39/69] iwlwifi: disable the buggy chain extension feature in HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340078223.6871.5.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 19 Jun 2012 04:57:03 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
Cc:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	"John W. Linville" <linville@...driver.com>
Subject: RE: [ 39/69] iwlwifi: disable the buggy chain extension feature in
 HW

On Mon, 2012-06-18 at 19:23 +0000, Grumbach, Emmanuel wrote:
> > Hi, this triggers the following build warning:
> > linux-stable/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c: In function
> > 'iwl_trans_pcie_tx_start':
> > linux-stable/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c:874:2: warning:
> > passing argument 1 of 'iwl_write_prph' from incompatible pointer type
> > [enabled by default]
> > linux-stable/drivers/net/wireless/iwlwifi/iwl-io.h:72:6: note: expected 'struct
> > iwl_bus *' but argument is of type 'struct iwl_trans *'
> > 
> > For 3.2, it should be passed as bus(trans) as other invocations.
> > 
> > >  	/* Enable DMA channel */
> > >  	for (chan = 0; chan < FH_TCSR_CHNL_NUM ; chan++)
> > >  		iwl_write_direct32(bus(trans),
> > FH_TCSR_CHNL_TX_CONFIG_REG(chan),
> 
> Correct

Thanks both, I'll fix this up.  No idea how I missed that warning.

Ben.

-- 
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)