lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jun 2012 04:59:52 +0100
From: Ben Hutchings <ben@...adent.org.uk>
To: Eugeni Dodonov <eugeni.dodonov@...el.com>
Cc: Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>,
linux-kernel@...r.kernel.org, stable@...r.kernel.org,
torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
alan@...rguk.ukuu.org.uk, Daniel Vetter <daniel.vetter@...ll.ch>,
Chris Wilson <chris@...is-wilson.co.uk>
Subject: Re: [ 04/69] drm/i915: fix up ivb plane 3 pageflips
On Mon, 2012-06-18 at 19:10 -0300, Eugeni Dodonov wrote:
> On 06/18/2012 06:55 PM, Herton Ronaldo Krzesinski wrote:
> >> + default:
> >> + WARN_ONCE(1, "unknown plane in flip command\n");
> >> + ret = -ENODEV;
> >> + goto err;
> >
> > Shouldn't this have been "goto err_unpin;"?
> >
> > It's not a problem in the backport for 3.2, same code is in the original
> > patch, just noticed it seems a problem while looking at it; but by what
> > changelog says the default case is said to not trigger in "practice"
> > (catch programming error), so I think it doesn't pose a real issue in
> > practice.
>
> You are right, it should be err_unpin. I sent a patch rectifying this.
>
> In practice, this should not happen, but still, better be safe than
> sorry. Thanks for catching that!
So should I drop this until the second patch is upstream?
Ben.
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.
Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)
Powered by blists - more mailing lists