linux-kernel - Re: linux-next: Tree for Jun 18 (kmsg problems)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2012 08:37:20 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, Kay Sievers <kay@...y.org>
Subject: Re: linux-next: Tree for Jun 18 (kmsg problems)

Hi Greg,

On Mon, 18 Jun 2012 15:15:35 -0700 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>
> > Caused by commit e2ae715d66bf ("kmsg - kmsg_dump() use iterator to
> > receive log buffer content") from the driver-core.current tree.
> 
> I'm building my tree right now, and I can't seem to hit this.

You need CONFIG_PRINTK turned off ...

> > This was reported a few days ago.  Why is it not fixed yet?
> 
> It was reported Friday evening, on a holiday weekend for some of us, we
> are trying the best we can :)

Ah ha, another of those pesky holiday things :-)

> > Especially since it is in a branch that is supposedly "bug fixes"?
> 
> It fixes up a reported problem, and we had 3 people test it and said it
> resolved the issue for them, no build problems reported.

My usual mantra is that if your patch is modifying code that clearly
depends on a CONFIG option, you must test with that option both on and
off. I see build problems in linux-next all the time where this has not
been done.  :-(

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped