linux-kernel - Re: [PATCH] epoll: Improved support for multi-threaded clients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2012 16:24:35 -0700
From:	"Paton J. Lewis" <palewis@...be.com>
To:	Christof Meerwald <cmeerw@...erw.org>
CC:	Alexander Viro <viro@...iv.linux.org.uk>,
	Jason Baron <jbaron@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Paul Holland <pholland@...be.com>,
	Davide Libenzi <davidel@...ilserver.org>
Subject: Re: [PATCH] epoll: Improved support for multi-threaded clients

Christof,

We believe that EPOLLONESHOT is required in order to make any 
sensible use of calling epoll_wait on a single epoll set concurrently 
in multiple threads. So in that sense the new functionality is really 
only useful for coordinating resource deletion between threads when 
using EPOLLONESHOT. However, when EPOLLONESHOT is not used, 
EPOLL_CTL_DISABLE still disables the item, and can be used solely for 
that purpose if the caller intends to re-enable the item via 
EPOLL_CTL_MOD and doesn't wish to incur the additional overhead 
associated with deleting and re-adding an item.

Thank you,
Pat

At 6/16/2012 11:47 AM, Christof Meerwald wrote:
>On Mon, 11 Jun 2012 15:34:49 -0700, Paton Lewis wrote:
> > This patch introduces the new epoll_ctl command EPOLL_CTL_DISABLE, which
> > disables the associated epoll item and returns -EBUSY if the 
> epoll item is not
> > currently in the epoll ready queue. This allows multiple threads to use a
> > mutex to determine when it is safe to delete an epoll item and 
> its associated
> > resources. This allows epoll items to be deleted and closed efficiently and
> > without error.
>
>Do you assume that EPOLLONESHOT is being used for this to work or
>would you expect your patch to also address the case where
>EPOLLONESHOT is not used?
>
>
>Christof
>
>--
>
>http://cmeerw.org                             sip:cmeerw at cmeerw.org
>mailto:cmeerw at cmeerw.org                   xmpp:cmeerw at cmeerw.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/