linux-kernel - Re: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should be bool not tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120619003047.GA25098@kroah.com>
Date:	Mon, 18 Jun 2012 17:30:47 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should
 be bool not tristate

On Mon, Jun 18, 2012 at 07:16:10PM -0500, H Hartley Sweeten wrote:
> On Monday, June 18, 2012 4:59 PM, Greg KH wrote:
> > On Fri, Jun 15, 2012 at 03:20:04PM -0700, H Hartley Sweeten wrote:
> >> The menuconfig options to enable the misc, isa, pci, pcmcia, and usb
> >> comedi driver selections should be bool not tristate. They don't
> >> directly affect the building of the kernel they just allow other
> >> options to be selected.
> >> 
> >> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> >> Cc: Ian Abbott <abbotti@....co.uk>
> >> Cc: Frank Mori Hess <fmhess@...rs.sourceforge.net>
> >> ---
> >>  drivers/staging/comedi/Kconfig |   10 +++++-----
> >>  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > This patch breaks the build for me with lots of the following errors:
> > ERROR: "subdev_8255_init" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
> > ERROR: "subdev_8255_cleanup" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
> 
> Strange. I just applied only this patch and the build still works
> on my system. I don't see any reason why this change of the
> menuconfig options from tristate to bool would cause the
> problem you are seeing.
> 
> I do see a problem in the Kconfig for the adl_pci7296 driver.
> 
> Based on the error message above, it requires COMEDI_8255. But that
> option is not listed as a depends or select. I noticed a couple other
> comedi drivers with the same issue.

Below is the .config I use.  Apply your patch, and select 'y' for the
different options it asks for when running 'make oldconfig' and then see
the build errors.



Download attachment ".config" of type "application/x-config" (106331 bytes)