lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Jun 2012 19:16:10 -0500 From: H Hartley Sweeten <hartleys@...ionengravers.com> To: Greg KH <gregkh@...uxfoundation.org> CC: Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, "abbotti@....co.uk" <abbotti@....co.uk>, "fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net> Subject: RE: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should be bool not tristate On Monday, June 18, 2012 4:59 PM, Greg KH wrote: > On Fri, Jun 15, 2012 at 03:20:04PM -0700, H Hartley Sweeten wrote: >> The menuconfig options to enable the misc, isa, pci, pcmcia, and usb >> comedi driver selections should be bool not tristate. They don't >> directly affect the building of the kernel they just allow other >> options to be selected. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com> >> Cc: Ian Abbott <abbotti@....co.uk> >> Cc: Frank Mori Hess <fmhess@...rs.sourceforge.net> >> --- >> drivers/staging/comedi/Kconfig | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) > > This patch breaks the build for me with lots of the following errors: > ERROR: "subdev_8255_init" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined! > ERROR: "subdev_8255_cleanup" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined! Strange. I just applied only this patch and the build still works on my system. I don't see any reason why this change of the menuconfig options from tristate to bool would cause the problem you are seeing. I do see a problem in the Kconfig for the adl_pci7296 driver. Based on the error message above, it requires COMEDI_8255. But that option is not listed as a depends or select. I noticed a couple other comedi drivers with the same issue. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists