linux-kernel - RE: [PATCH] sched: Folding nohz load accounting more accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001cd4e33$496f6c30$dc4e4490$@net>
Date:	Tue, 19 Jun 2012 08:50:29 -0700
From:	"Doug Smythies" <dsmythies@...us.net>
To:	"'Peter Zijlstra'" <peterz@...radead.org>,
	"'Yong Zhang'" <yong.zhang0@...il.com>
Cc:	"'Charles Wang'" <muming.wq@...il.com>,
	<linux-kernel@...r.kernel.org>, "'Ingo Molnar'" <mingo@...hat.com>,
	"'Tao Ma'" <tm@....ma>,
	'含黛' <handai.szj@...bao.com>,
	"'Thomas Gleixner'" <tglx@...utronix.de>,
	"Doug Smythies" <dsmythies@...us.net>
Subject: RE: [PATCH] sched: Folding nohz load accounting more accurate

>> On Tue, 2012-06-19 at 14:08 +0800, Yong Zhang wrote:
>  On 2012.06.19 02:19 -0700, Peter Zijlstra wrote:

>>>  	/*
>>> +	 * If we're still outside the sample window, we're done.
>>>  	 */
>>> +	if (time_before(jiffies, this_rq->calc_load_update))
>>> +		return;

>> 	else if (time_before(jiffies, calc_load_update + 10)
>> 		this_rq->calc_load_update = calc_load_update + LOAD_FREQ;
>> 	else
>> 		this_rq->calc_load_update = calc_load_update;
>> 
>> Otherwise if you woke after the sample window, we loose on sample?
>> And maybe we need local variable to cache calc_load_update.

> Ah indeed, although I'd write it like:

>	this_rq->calc_load_update = calc_load_update;
>	if (time_before(jiffies, this_rq->calc_load_update + 10)
>		this_rq->calc_load_update += LOAD_FREQ;

Note missing end brace:
	if (time_before(jiffies, this_rq->calc_load_update + 10))

My automated 63 hour test has been terminated, the code changed
and the test re-started.

The attached png file is what I had so far, but it will be replaced.
Summary: Looked good, so far.


Download attachment "n_processes_peter35.png" of type "image/png" (34780 bytes)