linux-kernel - RE: [PATCH] sched: Folding nohz load accounting more accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340185528.21745.86.camel@twins>
Date:	Wed, 20 Jun 2012 11:45:28 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Doug Smythies <dsmythies@...us.net>
Cc:	'Yong Zhang' <yong.zhang0@...il.com>,
	'Charles Wang' <muming.wq@...il.com>,
	linux-kernel@...r.kernel.org, 'Ingo Molnar' <mingo@...hat.com>,
	'Tao Ma' <tm@....ma>,
	'含黛' <handai.szj@...bao.com>,
	'Thomas Gleixner' <tglx@...utronix.de>
Subject: RE: [PATCH] sched: Folding nohz load accounting more accurate

On Tue, 2012-06-19 at 08:50 -0700, Doug Smythies wrote:
> My automated 63 hour test has been terminated, the code changed
> and the test re-started. 

There's another boo-boo in there:


> @@ -2369,11 +2493,35 @@ void get_avenrun(unsigned long *loads, unsigned long offset, int shift)
>   */
>  void calc_global_load(unsigned long ticks)
>  {
> -       long active;
> +       long active, delta;
>  
>         if (time_before(jiffies, calc_load_update + 10))
>                 return;
>  
> +       /*
> +        * Fold the 'old' idle-delta to include all NO_HZ cpus.
> +        *
> +        *      cpu0    cpu1    cpu2    ..
> +        *
> +        * >--- [sample A]
> +        *
> +        *                      -> NOHZ
> +        *              -> NOHZ
> +        *      ->NOHZ
> +        *
> +        * >--- [sample B]
> +        *
> +        * >--- [sample C]
> +        *
> +        *      NOHZ-> (here)
> +        *
> +        * Since all CPUs went into NOHZ state, all 'missed' samples (B, C)
> +        * should include the folded idle-delta.
> +        */
> +       delta += calc_load_fold_idle();

This gives a gcc warning about use without init, which is true, that should be:

	delta = calc_load_fold_idle();

> +       if (delta)
> +               atomic_long_add(delta, &calc_load_tasks);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/