linux-kernel - Re: Q: return of pinctrl_register and handing at drivers that use this function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZAg8A2kms=mWvE6-HpMQcW_GskHze=4_Psn9_6zL7k9g@mail.gmail.com>
Date:	Wed, 20 Jun 2012 09:52:06 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"devendra.aaru" <devendra.aaru@...il.com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: Q: return of pinctrl_register and handing at drivers that use
 this function

On Mon, Jun 18, 2012 at 4:42 PM, devendra.aaru <devendra.aaru@...il.com> wrote:
> On Mon, Jun 18, 2012 at 8:08 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
>> On Mon, Jun 18, 2012 at 2:04 PM, devendra.aaru <devendra.aaru@...il.com> wrote:
>>
>>> So checking the return value of pinctrl_register with IS_ERR is not required.
>>
>> Nope.
>
> You mean to say that the check "IS_ERR(ret_ptr)" is not required? or
> the other way like its also needed.

I mean it shall be tested like this:

if (!pinmctrl_register(&foo)) {
    /* error case */
}

No IS_ERR() business.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/