linux-kernel - Re: [PATCH v2] regulator: max77686: Implement .set_ramp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120620101824.GG3978@opensource.wolfsonmicro.com>
Date:	Wed, 20 Jun 2012 11:18:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Yadwinder Singh Brar <yadi.brar01@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Chiwoong Byun <woong.byun@...sung.com>,
	Axel Lin <axel.lin@...il.com>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>
Subject: Re: [PATCH v2] regulator: max77686: Implement .set_ramp_delay()
 callback.

On Wed, Jun 20, 2012 at 10:50:51AM +0530, Yadwinder Singh Brar wrote:
> This patch implements the .set_ramp_delay callback to set the ramp_delay on
> hardware for BUCK2/3/4 if ramp_delay is set in regulator constraints.

Applied, thanks.  It does seem reasonable to set the fastest ramp if the
ramp rate requested is over the maximum rate suported.

> This patch also do some cleaning work for unrequired members of
> struct max77686_data.

As Myungjoo said this really should have been split into a separate
patch, please don't do this in future.  One patch per change.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)