linux-kernel - Re: gpio_keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2012 01:53:40 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Roland Stigge <stigge@...com.de>
Cc:	dgdunix@...il.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: gpio_keys_polled.c and DT

Hi Roland,

On Tue, Jun 19, 2012 at 05:02:03PM +0200, Roland Stigge wrote:
> Hi,
> 
> as far as I can see, gpio_keys_polled.c currently doesn't support DT
> initialization. Is there a plan in this regard?
> 
> Rather than duplicating the respective code from gpio_keys.c, maybe
> gpio_keys.c could be changed to support a polled mode also? This way,
> gpio_keys_polled.c could be removed.

We had several attempts at gpio_keys and adding a polled mode and we
ended up with the driver getting too complex and having unwanted
dependencies. At the moment I believe that the split between gpio_keys.c
and gpio_keys_polled.c is justified even it it may lead to certain code
duplication.

However, if DT bindings are really the same we could split them off into
a separate library module used by both drivers.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/