linux-kernel - Re: [PATCH 02/12] usb: fix sillies in the metro USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FE78B62.4090106@suse.cz>
Date:	Sun, 24 Jun 2012 23:49:22 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	greg@...ah.com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jiri Slaby <jirislaby@...il.com>
Subject: Re: [PATCH 02/12] usb: fix sillies in the metro USB driver

On 06/22/2012 05:38 PM, Alan Cox wrote:
> Bits noticed doing the termios conversion
> 
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
> 
>  drivers/usb/serial/metro-usb.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
> index 81423f7..bad5f0c 100644
> --- a/drivers/usb/serial/metro-usb.c
> +++ b/drivers/usb/serial/metro-usb.c
> @@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb)
...
>  	if (tty && urb->actual_length) {
>  		/* Loop through the data copying each byte to the tty layer. */
>  		tty_insert_flip_string(tty, data, urb->actual_length);
>  
>  		/* Force the data to the tty layer. */
>  		tty_flip_buffer_push(tty);
> +		tty_kref_put(tty);
>  	}
> -	tty_kref_put(tty);

This doesn't seem right. (Depends on whether tty is non-null iff
urb->actual_length is non-zero.)

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/