linux-kernel - Re: [PATCH v5] fs: make dumpable=2 require fully qualified path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120625152853.1ec6a824.akpm@linux-foundation.org>
Date:	Mon, 25 Jun 2012 15:28:53 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org, Rob Landley <rob@...dley.net>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Alan Cox <alan@...ux.intel.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Doug Ledford <dledford@...hat.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	James Morris <james.l.morris@...cle.com>,
	Joe Korty <joe.korty@...r.com>, linux-doc@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v5] fs: make dumpable=2 require fully qualified path

On Mon, 25 Jun 2012 15:20:19 -0700
Kees Cook <keescook@...omium.org> wrote:

> On Mon, Jun 25, 2012 at 3:14 PM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> > On Mon, 25 Jun 2012 11:03:27 -0700
> > Kees Cook <keescook@...omium.org> wrote:
> >
> >> Instead of introducing a suid_dumpable=3 mode and breaking all users
> >> of mode 2, this only disables the unsafe portion of mode 2 (writing to
> >> disk via relative path).
> >
> > It would be nicer to generate the warning at configuration time rather than
> > at core-dumping time. __I have a feeling that's Hard To Do, but why?
> 
> I actually feel that this is much more discoverable because anyone
> trying to figure out why a crash isn't dumping core isn't going to be
> looking back in time through their dmesg to find the warning from
> setting the sysctl. Additionally, I think it's the same kind of thing
> that the other existing "Skipping core dump" printk messages are
> reporting.

People who don't discover we changed their kernel until after they lost
an important core dump will be sad.  Do both?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/