linux-kernel - Re: [PATCH] drivers: staging: android: binder.c: fix printk macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340692980.4177.6.camel@fourier.local.igalia.com>
Date:	Tue, 26 Jun 2012 08:43:00 +0200
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Sherwin Soltani <sherwin@...c.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	swetland@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: android: binder.c: fix printk macros

On Tue, 2012-06-26 at 02:00 -0400, Sherwin Soltani wrote:
> Change printk() messages to pr_* macros.
> 
> Signed-off-by: Sherwin Soltani <sherwin@...c.com>
> ---
>  drivers/staging/android/binder.c |   54 +++++++++++++++++++-------------------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index c283212..574e992 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -124,13 +124,13 @@ module_param_call(stop_on_user_error, binder_set_stop_on_user_error,
>  #define binder_debug(mask, x...) \
>  	do { \
>  		if (binder_debug_mask & mask) \
> -			printk(KERN_INFO x); \
> +			pr_info(x); \
>  	} while (0)
>  
>  #define binder_user_error(x...) \
>  	do { \
>  		if (binder_debug_mask & BINDER_DEBUG_USER_ERROR) \
> -			printk(KERN_INFO x); \
> +			pr_info(x); \
>  		if (binder_stop_on_user_error) \
>  			binder_stop_on_user_error = 2; \
>  	} while (0)
> @@ -418,7 +418,7 @@ repeat:
>  #if 1
>  	/* Sanity check */
>  	if (fdt->fd[fd] != NULL) {
> -		printk(KERN_WARNING "get_unused_fd: slot %d not NULL!\n", fd);
> +		pr_warn("get_unused_fd: slot %d not NULL!\n", fd);
>  		fdt->fd[fd] = NULL;
>  	}
>  #endif
> @@ -644,7 +644,7 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
>  		goto free_range;
>  
>  	if (vma == NULL) {
> -		printk(KERN_ERR "binder: %d: binder_alloc_buf failed to "
> +		pr_err("binder: %d: binder_alloc_buf failed to "
>  		       "map pages in userspace, no vma\n", proc->pid);

Instead of using the "binder: " prefix here and there and now that you
have changed to pr_* functions, you can define the pr_fmt macro at the
beginning of the file (just before the #include sentences).

Regards,

Sam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/