linux-kernel - Re: [PATCH] rtc: ds1307: Register offset moved to chip description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFD3CD15E9.315EBD6D-ONC1257A2A.004B4768-C1257A2A.004B476C@transmode.se>
Date:	Wed, 27 Jun 2012 15:42:14 +0200
From:	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Austin Boyle <Austin.Boyle@...atnet.com>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH] rtc: ds1307: Register offset moved to chip description

> 
> On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> > rtc: ds1307: Register offset moved to chip description
> > 
> > From: Austin Boyle <Austin.Boyle@...atnet.com>
> > 
> > Register offset is added to chip description instead of being hard-coded
> > into probe function.
> > 
> > Based on v3.5-rc4
> > 
> > Cc: Wolfram Sang <w.sang@...gutronix.de>
> > Cc: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > Cc: Alessandro Zummo <a.zummo@...ertech.it>
> > Signed-off-by: Austin Boyle <Austin.Boyle@...atnet.com>
> 
> I would ack this patch immediately if it added another type using this
> feature. But only changing already working code doesn't seem necessary
> to me.
> 
> Regards,
> 
>     Wolfram
> 

That was my gut feeling too.

  Jocke--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/