linux-kernel - Re: [PATCH] rtc: ds1307: Register offset moved to chip description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120627133332.GA21572@pengutronix.de>
Date:	Wed, 27 Jun 2012 15:33:32 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Austin Boyle <Austin.Boyle@...atnet.com>
Cc:	rtc-linux@...glegroups.com,
	Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: ds1307: Register offset moved to chip description

On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> rtc: ds1307: Register offset moved to chip description
> 
> From: Austin Boyle <Austin.Boyle@...atnet.com>
> 
> Register offset is added to chip description instead of being hard-coded
> into probe function.
> 
> Based on v3.5-rc4
> 
> Cc: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> Cc: Alessandro Zummo <a.zummo@...ertech.it>
> Signed-off-by: Austin Boyle <Austin.Boyle@...atnet.com>

I would ack this patch immediately if it added another type using this
feature. But only changing already working code doesn't seem necessary
to me.

Regards,

    Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)