linux-kernel - Re: [PATCH] asm-generic: fix compile breakage "'TAINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120627142233.GK24033@linux-sh.org>
Date:	Wed, 27 Jun 2012 23:22:34 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] asm-generic: fix compile breakage "'TAINT_WARN'
 undeclared"

On Wed, Jun 27, 2012 at 03:52:27PM +0200, Guennadi Liakhovetski wrote:
> TAINT_WARN is defined in kernel.h and used in asm-generic/bug.h. Not 
> including kernel.h there breaks build on sh:
> 
> In file included from linux/include/linux/thread_info.h:54,
>                  from linux/include/linux/preempt.h:9,
>                  from linux/include/linux/spinlock.h:50,
>                  from linux/include/linux/mmzone.h:7,
>                  from linux/include/linux/gfp.h:4,
>                  from linux/include/linux/mm.h:8,
>                  from linux/arch/sh/kernel/asm-offsets.c:13:
> linux/arch/sh/include/asm/thread_info.h: In function 'set_restore_sigmask':
> linux/arch/sh/include/asm/thread_info.h:172: error: 'TAINT_WARN' undeclared (first use in this function)
> linux/arch/sh/include/asm/thread_info.h:172: error: (Each undeclared identifier is reported only once
> linux/arch/sh/include/asm/thread_info.h:172: error: for each function it appears in.)
> 
> Also, since nothing in bug.h is usable from assembly, it is safe to extend 
> the "#ifndef __ASSEMBLY__" block over all WARN() macros.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>

Already fixed in mainline.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/