linux-kernel - Re: [char-misc fix for 3.5] mei: pci_resume: set IRQF_ONESHOT for msi request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67041533.Myjsgf8nbb@al>
Date:	Wed, 27 Jun 2012 16:58:35 +0200
From:	Lekensteyn <lekensteyn@...il.com>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [char-misc fix for 3.5] mei: pci_resume: set IRQF_ONESHOT for msi request_threaded_irq

On Wednesday 27 June 2012 17:14:20 Tomas Winkler wrote:
> when the default irq quick handler is used then IRQF_ONESHOT must be set
> otherwise the request fails and following error is displayed:
> 
> mei 0000:00:16.0: irq 48 for MSI/MSI-X
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 48
> mei 0000:00:16.0: request_threaded_irq failed: irq = 48.
> dpm_run_callback(): pci_pm_resume+0x0/0x140 returns -22
> PM: Device 0000:00:16.0 failed to resume async: error -22
> 
> Reported-by: Lekensteyn <lekensteyn@...il.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
Tested-by: Peter Wu <lekensteyn@...il.com>

(for the real name policy, if you prefer "Lekensteyn", it's fine too)

> ---
>  drivers/misc/mei/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
> index 7de1389..783fcd7 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device)
>  		err = request_threaded_irq(pdev->irq,
>  			NULL,
>  			mei_interrupt_thread_handler,
> -			0, mei_driver_name, dev);
> +			IRQF_ONESHOT, mei_driver_name, dev);
>  	else
>  		err = request_threaded_irq(pdev->irq,
>  			mei_interrupt_quick_handler,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/