linux-kernel - Re: [PATCH 03/23] perf: Add ability to attach user level registers dump to sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120627151059.GG20638@somewhere.redhat.com>
Date:	Wed, 27 Jun 2012 17:11:03 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	acme@...hat.com, a.p.zijlstra@...llo.nl, mingo@...e.hu,
	paulus@...ba.org, cjashfor@...ux.vnet.ibm.com, eranian@...gle.com,
	gorcunov@...nvz.org, tzanussi@...il.com, mhiramat@...hat.com,
	robert.richter@....com, fche@...hat.com,
	linux-kernel@...r.kernel.org, masami.hiramatsu.pt@...achi.com,
	drepper@...il.com, asharma@...com, benjamin.redelings@...cent.org
Subject: Re: [PATCH 03/23] perf: Add ability to attach user level registers
 dump to sample

On Tue, Jun 19, 2012 at 05:47:54PM +0200, Jiri Olsa wrote:
> @@ -4061,6 +4105,19 @@ void perf_prepare_sample(struct perf_event_header *header,
>  		}
>  		header->size += size;
>  	}
> +
> +	if (sample_type & PERF_SAMPLE_REGS_USER) {
> +		/* regs dump available bool */
> +		int size = sizeof(u64);
> +
> +		data->regs_user = perf_sample_regs_user(regs);
> +		if (data->regs_user) {
> +			u64 mask = event->attr.sample_regs_user;
> +			size += hweight64(mask) * sizeof(u64);
> +		}
> +
> +		header->size += size;

We'll need to remove the 64 bits registers for compat tasks but other than
that, it looks ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/