linux-kernel - Re: [PATCH next] kvm: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1340847281.16533.57.camel@joe2Laptop>
Date:	Wed, 27 Jun 2012 18:34:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
Cc:	Avi Kivity <avi@...hat.com>, Joerg Roedel <joerg.roedel@....com>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] kvm: Use pr_<level>

On Wed, 2012-06-27 at 21:44 -0300, Marcelo Tosatti wrote:
> The advantage is the added prefix?

All messages are automatically prefixed.
For instance:

> > -		printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
> > +		pr_warn("Fail to find correlated MSI-X entry!\n");

Now has a prefix that describes the module from which
the message originates.

> $ grep limit Documentation/CodingStyle 
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.

Read further:

However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/