linux-kernel - Re: [PATCH 12/16] tile/PCI: Factor 'pcibios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1340904647.2411.8.camel@zim.stowe>
Date:	Thu, 28 Jun 2012 11:30:47 -0600
From:	Myron Stowe <mstowe@...hat.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	Myron Stowe <myron.stowe@...hat.com>, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, rth@...ddle.net,
	ink@...assic.park.msu.ru, mattst88@...il.com,
	linux@....linux.org.uk, starvik@...s.com, jesper.nilsson@...s.com,
	tony.luck@...el.com, fenghua.yu@...el.com, monstr@...str.eu,
	ralf@...ux-mips.org, yasutake.koichi@...panasonic.com,
	jejb@...isc-linux.org, deller@....de, benh@...nel.crashing.org,
	paulus@...ba.org, lethal@...ux-sh.org, davem@...emloft.net,
	gxt@...c.pku.edu.cn, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, chris@...kel.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/16] tile/PCI: Factor 'pcibios_setup()' out of tile

On Tue, 2012-06-26 at 09:18 -0400, Chris Metcalf wrote:
> On 6/25/2012 11:32 PM, Myron Stowe wrote:
> > The PCI core provides a generic (__weak) 'pcibios_setup()' routine
> > that can be used by all architectures as a default.  Drop tile's
> > architecture specific version in favor of that as it does not need to be
> > over-ridden.
> >
> > Signed-off-by: Myron Stowe <myron.stowe@...hat.com>
> > ---
> >
> >  arch/tile/kernel/pci.c |   10 ----------
> >  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> Acked-by: Chris Metcalf <cmetcalf@...era.com>
> 
> In our internal tree we have x86-like support for "pci=off" here.  When I
> push that I can just push it as a new function to override the removed one,
> so I'm happy with your change as proposed.

Yes, that should be fine.  Just an FYI - when you introduce the
over-ride, I believe that it should be __init and not __devinit as the
previous tile version of 'pcibios_setup()' was.

>   But perhaps it would make sense
> to move the support for "pci=off" to common code, since multiple
> architectures handle this the same way?

Looking at the tree I only see three of the architectures currently
using/implementing "pci=off" (four with the 'tile' addition).  Perhaps
there is a way to avoid such but it seems like adding this to the core
would require introducing the global variable 'pci_probe' which seems
like unnecessary pollution?

Myron


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/