linux-kernel - Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3ynlzk8.fsf@sejong.aot.lge.com>
Date:	Mon, 02 Jul 2012 10:30:31 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Hitoshi Mitake <h.mitake@...il.com>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...radead.org>
Subject: Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem

Hi,

On Mon,  2 Jul 2012 00:06:23 +0900, Hitoshi Mitake wrote:
> As Namhyung Kim pointed, there are confused namings and descriptions
> of words "cycle" and "clock" in mem-memset.c and mem-memcpy.c.
>
> With the option "-c" (or "--clock", now renamed as "--cycle"), mem
> subsystem measures cost of memset() and memcpy() with cpu-cycles
> event.
>
> But current mem subsystem source code contains lots of confused
> variable namings and descriptions with "clock" (e.g. the variable
> use_clock). This is a very bad style because there is another software
> event named "cpu-clock". This patch replaces wrong usage of "clock" to
> "cycle".
>

Could you fix the Documentation/perf-bench.txt also?

Thanks,
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/