linux-kernel - Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201207021517.31537.arnd@arndb.de>
Date:	Mon, 2 Jul 2012 15:17:31 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Vinayak Holikatti <vinholikatti@...il.com>
Cc:	James.Bottomley@...senpartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...aro.org,
	linux-samsung-soc@...r.kernel.org, santoshsy@...il.com,
	arnd@...aro.org, girish.shivananjappa@...aro.org,
	saugata.das@...aro.org, vishak.g@...sung.com, venkat@...aro.org,
	k.rajesh@...sung.com, yejin.moon@...sung.com, dsaxena@...aro.org,
	ilho215.lee@...sung.com, nala.la@...sung.com,
	stephen.doel@...aro.org, sreekumar.c@...sung.com
Subject: Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

On Monday 02 July 2012, Vinayak Holikatti wrote:
> 
> This patch separates PCI and core UFS host controller driver.
> In the current implementation PCI specific code is with ufshcd.c.
> To provide way for adding multiple bus glue driver, this patch
> separates PCI layer from ufshcd core. Now ufshcd compiles as separate
> module and ufshcd-pci as separate module.
> 
> Signed-off-by: Vinayak Holikatti <vinholikatti@...il.com>
> Signed-off-by: Santosh Yaraganavi <santoshsy@...il.com>

Hi Vinayak,

This patch looks good at first sight, but it's a little hard to
review in the form that you are posting.

I would recommend that you split this patch into two separate
changesets, where you do all the changes to existing code in the
first patch, and only move but don't change code in the second one
that creates the new file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/