linux-kernel - Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201207021520.03774.arnd@arndb.de>
Date:	Mon, 2 Jul 2012 15:20:03 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Vinayak Holikatti <vinholikatti@...il.com>
Cc:	James.Bottomley@...senpartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...aro.org,
	linux-samsung-soc@...r.kernel.org, santoshsy@...il.com,
	arnd@...aro.org, girish.shivananjappa@...aro.org,
	saugata.das@...aro.org, vishak.g@...sung.com, venkat@...aro.org,
	k.rajesh@...sung.com, yejin.moon@...sung.com, dsaxena@...aro.org,
	ilho215.lee@...sung.com, nala.la@...sung.com,
	stephen.doel@...aro.org, sreekumar.c@...sung.com
Subject: Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd

On Monday 02 July 2012, Vinayak Holikatti wrote:
> +static struct amba_id ufshcd_amba_ids[] = {
> +       {
> +               /* Fake id for Primecell.*/
> +               .id     = 0x00041FF0,
> +               .mask   = 0x000fffff,
> +       },
> +       { 0, 0 },
> +};

Hi Vinayak,

Can you explain where this fake ID comes from? Is this ID actually
used by any hardware that is around somewhere? If not, I think it
would be better not to provide an AMBA driver at all, but instead
use the platform driver from patch 2 for all non-PCI uses.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/