linux-kernel - Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdPZaNDW+XCrf9Mse-N3jtgtrrx9Z0+W1YZX8nPETa7ZZFB1w@mail.gmail.com>
Date:	Mon, 2 Jul 2012 21:26:09 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Bryan Wu <bryan.wu@...onical.com>
Cc:	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove

On Mon, Jul 2, 2012 at 7:23 PM, Bryan Wu <bryan.wu@...onical.com> wrote:
> On Mon, Jul 2, 2012 at 4:40 PM, Devendra Naga <devendra.aaru@...il.com> wrote:
>> the platform_set_drvdata (pdev, NULL) to be set at the remove of the
>> driver, as we have set the platform data to led at probe.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
>
> Nice catch. I applied this patch in my for-next branch.
>
> But I also find the same issue in other LED drivers, are you
> interested in fixing them?
>
Yes, i will do those.
I will send out changes...
> Thanks,
> -Bryan
>

Thanks
>> ---
>>  drivers/leds/leds-mc13783.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
>> index 4cc6a2e..6515c11 100644
>> --- a/drivers/leds/leds-mc13783.c
>> +++ b/drivers/leds/leds-mc13783.c
>> @@ -372,6 +372,7 @@ static int __devexit mc13783_led_remove(struct platform_device *pdev)
>>
>>         mc13xxx_unlock(dev);
>>
>> +       platform_set_drvdata(pdev, NULL);
>>         kfree(led);
>>         return 0;
>>  }
>> --
>> 1.7.9.5
>>
>
>
>
> --
> Bryan Wu <bryan.wu@...onical.com>
> Kernel Developer    +86.186-168-78255 Mobile
> Canonical Ltd.      www.canonical.com
> Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/