linux-kernel - Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120702160340.GG25093@opensource.wolfsonmicro.com>
Date:	Mon, 2 Jul 2012 17:03:40 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs

On Mon, Jul 02, 2012 at 09:40:06AM -0600, Stephen Warren wrote:
> On 07/01/2012 12:23 PM, Mark Brown wrote:

> > ...this just seems rubbish, why aren't we just fixing the device
> > tree code and why are we doing this at the device tree level rather
> > than as a general gpiolib thing?

> It is being fixed in the DT code:

> https://lkml.org/lkml/2012/6/18/468

Is that patch actually being applied (especially with Grant's free time
issues)?  I've still got the patch sitting in my inbox since it wasn't
clear what was going on.

> However, it seemed best to make the regulator code work both before
> and after that patch.

I'd be kind of inclined to just leave it broken to be honest rather than
having a huge comment and dodgy code.

> This issue can't be fixed only in gpio_request(); of_get_named_gpio()
> needs the GPIO driver to be probed/registered to even be able to parse
> the GPIO ID out of the DT; it makes a call into the GPIO driver as

Oh, ick.  :/

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)