linux-kernel - Re: [PATCH] HID: magicmouse: Implement Multi-touch Protocol B (MT-B)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FF1ED8C.2080805@canonical.com>
Date:	Mon, 02 Jul 2012 11:50:52 -0700
From:	Chase Douglas <chase.douglas@...onical.com>
To:	Henrik Rydberg <rydberg@...omail.se>
CC:	Yufeng Shen <miletus@...omium.org>, linux-input@...r.kernel.org,
	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org,
	Daniel Kurtz <djkurtz@...omium.org>,
	Andrew de los Reyes <adlr@...omium.org>
Subject: Re: [PATCH] HID: magicmouse: Implement Multi-touch Protocol B (MT-B)

On 07/02/2012 03:07 AM, Henrik Rydberg wrote:
> On Thu, Jun 28, 2012 at 03:54:31PM -0400, Yufeng Shen wrote:
>> The driver for Apple Magic Trackpad/Mouse currently uses
>> Multi-touch Protocol A (MT-A) to report touch events and uses
>> ABS_MT_TRACKING_ID to do finger tracking. The fact of the device
>> being able to track individual finger makes it possible to
>> report touch events using MT-B. This patch adds the support
>> for the driver to report MT-B and makes it configurable through
>> module parameter so that existing codes that are relying on its
>> MT-A implemtation don't get affected.
>
> Are there any such codes? Most systems, if not all, seem to use mtdev,
> which can handle both protocols. I do not think a parameter switch is
> a good idea. Switching to MT-B or leaving things as is look like the
> viable options.

Yes, let's just switch to MT-B :). Part of open source is that one can 
look at other implementations to figure out how to make your own new 
device work. We don't want to proliferate MT-A since MT-B is the way 
forward.

In fact, I would also suggest preceding this patch with one that removes 
the switch to turn touch reporting on and off. It's really unnecessary. 
I bet no one in the world turns it off :).

-- Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/