linux-kernel - Re: [PATCH 3/3] fs/sysv: stop using write_super and s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120703151313.36e85254@pyramind.ukuu.org.uk>
Date:	Tue, 3 Jul 2012 15:13:13 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Linux FS Maling List <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 3/3] fs/sysv: stop using write_super and s_dirt

> drity and then setting the s_dirt flag. And when 'write_super()' is executed to
> handle the s_dirt flag, we just update the timestamp and again mark the
> superblock buffer as dirty. Seems pointless.

It's the way sysv itself does stuff. The timestamp on v7/sys3/sys5
reflects the clock on the box. A lot of ancient boxes with no decent
hardware clocks used to reset the system time off the root fs superblock
on a loss of power.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/