linux-kernel - Re: [PATCH 3/3] fs/sysv: stop using write_super and s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341326690.2979.84.camel@sauron.fi.intel.com>
Date:	Tue, 03 Jul 2012 17:44:50 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Linux FS Maling List <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 3/3] fs/sysv: stop using write_super and s_dirt

On Tue, 2012-07-03 at 15:13 +0100, Alan Cox wrote:
> > drity and then setting the s_dirt flag. And when 'write_super()' is executed to
> > handle the s_dirt flag, we just update the timestamp and again mark the
> > superblock buffer as dirty. Seems pointless.
> 
> It's the way sysv itself does stuff. The timestamp on v7/sys3/sys5
> reflects the clock on the box. A lot of ancient boxes with no decent
> hardware clocks used to reset the system time off the root fs superblock
> on a loss of power.

Oh, OK, thanks for the info. Do you think I need to take more efforts to
preserve the behavior?

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)