linux-kernel - Re: [PATCH 2/2] Made core dump functionality optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120703050908.GA14527@leaf>
Date:	Mon, 2 Jul 2012 22:09:08 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Alex Kelly <alex.page.kelly@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Paris <eparis@...hat.com>, WANG Cong <amwang@...hat.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Nikhil Rao <ncrao@...gle.com>,
	Dan Ballard <dan@...dstab.net>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, Alex <eshink@...il.com>
Subject: Re: [PATCH 2/2] Made core dump functionality optional

On Tue, Jul 03, 2012 at 12:55:52PM +0800, Cong Wang wrote:
> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@...il.com> wrote:
> > From: Alex <eshink@...il.com>
> >
> > Adds an expert Kconfig option, CONFIG_COREDUMP, which allows disabling of core dump.
> > This saves approximately 2.6k in the compiled kernel, and complements CONFIG_ELF_CORE,
> > which now depends on it.
> >
> > CONFIG_COREDUMP also disables coredump-related sysctls, except for suid_dumpable and
> > related functions, which are necessary for ptrace.
> >
> > Signed-off-by: Alex Kelly <alex.page.kelly@...il.com>
> > Reviewed-by: Josh Triplett <josh@...htriplett.org>
> 
> Looks good, just one nitpick: would CONFIG_CORE_DUMP be better than
> CONFIG_COREDUMP?

The kernel seems pretty split on that question, according to git grep;
"coredump" appears sufficiently often that changing the config option
name doesn't seem worth respinning the patch for.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/