linux-kernel - Re: [PATCH 1/2] Moved core dump functionality into its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Jul 2012 15:02:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Alex Kelly <alex.page.kelly@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alex <eshink@...il.com>
Subject: Re: [PATCH 1/2] Moved core dump functionality into its own file

On Tue, 3 Jul 2012 12:53:34 +0800
Cong Wang <xiyou.wangcong@...il.com> wrote:

> On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@...il.com> wrote:
> > From: Alex <eshink@...il.com>
> >
> > This was done in preparation for making core dump functionality optional.
> >
> > The variable "suid_dumpable" and associated functions are left in fs/exec.c
> > because they're used elsewhere, such as in ptrace.
> >
> > Signed-off-by: Alex Kelly <alex.page.kelly@...il.com>
> > Reviewed-by: Josh Triplett <josh@...htriplett.org>
> 
> Looks good to me:

Me too, but the first patch conflicts somewhat with a few pending
changes in linux-next.  I could fix them up, but would prefer that the
result be tested.  Alex, could you please redo the patches against
linux-next or mmotm?

Also, the patch titles could be improved.  I suggest

	coredump: move core dump functionality into its own file
	coredump: make core dump functionality optional

Documentation/SubmittingPatches section 15 describes the thinking here.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/