linux-kernel - Re: [Patch] mm/policy: use int instead of unsigned for nid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1207032342120.32556@chino.kir.corp.google.com>
Date:	Tue, 3 Jul 2012 23:43:40 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Cong Wang <amwang@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	WANG Cong <xiyou.wangcong@...il.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	linux-mm@...ck.org
Subject: Re: [Patch] mm/policy: use int instead of unsigned for nid

On Wed, 4 Jul 2012, Cong Wang wrote:

> From: WANG Cong <xiyou.wangcong@...il.com>
> 
> 'nid' should be 'int', not 'unsigned'.
> 

unsigned is already of type int, so you're saying these occurrences should 
become signed, but that's not true since they never return NUMA_NO_NODE.  
They are all safe returning unsigned.

And alloc_page_interleave() doesn't exist anymore since the sched/numa 
bits were merged into sched/core, so nobody could apply this patch anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/