linux-kernel - Re: [Patch] mm/policy: use int instead of unsigned for nid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Jul 2012 13:37:31 +0000 (UTC)
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org
Subject: Re: [Patch] mm/policy: use int instead of unsigned for nid

On Wed, 04 Jul 2012 at 06:43 GMT, David Rientjes <rientjes@...gle.com> wrote:
> On Wed, 4 Jul 2012, Cong Wang wrote:
>
>> From: WANG Cong <xiyou.wangcong@...il.com>
>> 
>> 'nid' should be 'int', not 'unsigned'.
>> 
>
> unsigned is already of type int, so you're saying these occurrences should 
> become signed, but that's not true since they never return NUMA_NO_NODE.  
> They are all safe returning unsigned.
>

Yeah, I knew, just thought using 'int' is consistent, this is a
trivial patch, not a bugfix.

> And alloc_page_interleave() doesn't exist anymore since the sched/numa 
> bits were merged into sched/core, so nobody could apply this patch anyway.

Ah, I made this patch against linus tree...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/