linux-kernel - Re: [PATCH 04/10] perf, x86: Making hardware events translations available in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120704163543.GB7533@infradead.org>
Date:	Wed, 4 Jul 2012 13:35:43 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Jiri Olsa <jolsa@...hat.com>, mingo@...e.hu, paulus@...ba.org,
	cjashfor@...ux.vnet.ibm.com, fweisbec@...il.com,
	eranian@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] perf, x86: Making hardware events translations
 available in sysfs

Em Wed, Jul 04, 2012 at 02:14:48PM +0200, Peter Zijlstra escreveu:
> On Wed, 2012-07-04 at 14:01 +0200, Jiri Olsa wrote:
> > >   ret = sprintf(page, "event=0x%02llx", event);
> > >   if (umask)
> > >     ret += sprintf(page + ret, ",umask=0x%02llx", umask);
> > >   if (inv)
> > >     ret += sprintf(page + ret, ",inv");
> > >   if (cmask)
> > >     ret += sprintf(page + ret, ",cmask=0x%02llx", cmask);
> > >   sprintf(page + ret, "\n");
> 
> There's a ret += missing there.

And also don't use sprintf or snprintf, use scnprintf, the former have
confusing semantics for the return value, see the man pages.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/