linux-kernel - Re: [PATCH 05/19] Staging: xgifb: Improve debug strings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Jul 2012 10:09:54 +0200
From:	Miguel Gómez <magomez@...lia.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	arnaud.patard@...-net.org, gregkh@...uxfoundation.org,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/19] Staging: xgifb: Improve debug strings.

Hi!

> On Thu, Jul 05, 2012 at 04:45:48PM +0200, Miguel Gómez wrote:
>>   	if (!htotal || !vtotal) {
>> -		pr_debug("XGIfb: Invalid 'var' information\n");
>> +		pr_debug("Invalid 'var' information\n");
> [...]
>> -		pr_err("xgifb: invalid value for option: %s\n", fullopt);
>> +		pr_err("Invalid value for option: %s\n", fullopt);
> [...]
>> -	pr_info("xgifb: options: %s\n", options);
>> +	pr_info("Options: %s\n", options);
>
> Can you really remove the driver prefix?

As the pr format is defined as

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

it will include the module name for free.

>>   	if (reg1 != 0xa1) { /*I/O error */
>> -		dev_err(&pdev->dev, "I/O error!!!");
>> +		dev_err(&pdev->dev, "I/O error!!!\n");
>
> Those exclamation marks are just redundant noise.

Written down for the next round ;)

>> -		dev_err(&pdev->dev, "unable request memory size %x\n",
>> +		dev_err(&pdev->dev, "Unable request memory size %x\n",
> [...]
>> -		dev_err(&pdev->dev, "no supported video mode found\n");
>> +		dev_err(&pdev->dev, "No supported video mode found\n");
> [...]
>> -		dev_info(&pdev->dev, "added MTRR\n");
>> +		dev_info(&pdev->dev, "Added MTRR\n");
> [...]
>> -		dev_err(&pdev->dev, "video BIOS not available\n");
>> +		dev_err(&pdev->dev, "Video BIOS not available\n");
> [...]
>> -	dev_err(&pdev->dev, "video BIOS corrupted\n");
>> +	dev_err(&pdev->dev, "Video BIOS corrupted\n");
>
> What is the improvement?

Capitalizing the first letter, just to keep coherency. It's not the most 
important change in the world, but it's nice :)

Regards!

-- 
Miguel Gómez
Igalia - http://www.igalia.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/