linux-kernel - Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FF69DD3.9060009@igalia.com>
Date:	Fri, 06 Jul 2012 10:12:03 +0200
From:	Miguel Gómez <magomez@...lia.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
CC:	arnaud.patard@...-net.org, gregkh@...uxfoundation.org,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

Hi!

> On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote:
>> +		if ((pVBInfo->VBType & VB_SIS301LV) &&
>> +		    !(pVBInfo->TVInfo & TVSetHiVision)) {
>> +			if ((pVBInfo->TVInfo & TVSimuMode) &&
>> +			    (pVBInfo->TVInfo & TVSetPAL)) {
>> +				if (pVBInfo->VBType & VB_SIS301LV) {
>> +					if (!(pVBInfo->TVInfo &
>> +					      (TVSetYPbPr525p |
>> +					       TVSetYPbPr750p |
>> +					       TVSetHiVision)))
>> +						tempbx += 40;
>> +				} else {
>> +					tempbx += 40;
>
> I think this could be simplified even more - both branches end up doing
> the same?!

I'll give it a look again :)

Regards!


-- 
Miguel Gómez
Igalia - http://www.igalia.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/