linux-kernel - Re: [PATCH] mfd: max77686: Remove unused iolock mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 6 Jul 2012 17:12:31 +0900
From:	Kyungmin Park <kmpark@...radead.org>
To:	Axel Lin <axel.lin@...il.com>
Cc:	SamuelOrtiz <sameo@...ux.intel.com>,
	Chiwoong Byun <woong.byun@...sung.com>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max77686: Remove unused iolock mutex

Acked-by: Kyungmin Park <kyungmin.park@...sung.com>

On Fri, Jul 6, 2012 at 4:32 PM, Axel Lin <axel.lin@...il.com> wrote:
> Now this driver is using regmap API, the iolock mutex is not used and can be
> removed.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/max77686.c               |    3 ---
>  include/linux/mfd/max77686-private.h |    1 -
>  2 files changed, 4 deletions(-)
>
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 11e5601..9e7e1d3 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -27,7 +27,6 @@
>  #include <linux/i2c.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>
>  #include <linux/mfd/core.h>
>  #include <linux/mfd/max77686.h>
>  #include <linux/mfd/max77686-private.h>
> @@ -79,8 +78,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c,
>         max77686->wakeup = pdata->wakeup;
>         max77686->irq_gpio = pdata->irq_gpio;
>
> -       mutex_init(&max77686->iolock);
> -
>         if (regmap_read(max77686->regmap,
>                          MAX77686_REG_DEVICE_ID, &data) < 0) {
>                 dev_err(max77686->dev,
> diff --git a/include/linux/mfd/max77686-private.h b/include/linux/mfd/max77686-private.h
> index 962f65e..d327d49 100644
> --- a/include/linux/mfd/max77686-private.h
> +++ b/include/linux/mfd/max77686-private.h
> @@ -219,7 +219,6 @@ struct max77686_dev {
>         struct device *dev;
>         struct i2c_client *i2c; /* 0xcc / PMIC, Battery Control, and FLASH */
>         struct i2c_client *rtc; /* slave addr 0x0c */
> -       struct mutex iolock;
>
>         int type;
>
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/