linux-kernel - Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FF70A49.3040802@gmail.com>
Date:	Fri, 06 Jul 2012 11:54:49 -0400
From:	Daniel Hazelton <dshadowwolf@...il.com>
To:	Kyungmin Park <kmpark@...radead.org>
CC:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

On 07/06/2012 11:32 AM, Kyungmin Park wrote:
> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
>
> On Sat, Jul 7, 2012 at 12:28 AM, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Cc: Kyungmin Park <kyungmin.park@...sung.com>
>> ---
>>  drivers/staging/ccg/ccg.c |    8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
>> index a5b36a9..62f5d92 100644
>> --- a/drivers/staging/ccg/ccg.c
>> +++ b/drivers/staging/ccg/ccg.c
>> @@ -564,9 +564,7 @@ static int rndis_function_bind_config(struct ccg_usb_function *f,
>>                 return -1;
>>         }
>>
>> -       pr_info("%s MAC: %02X:%02X:%02X:%02X:%02X:%02X\n", __func__,
>> -               rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> -               rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> +       pr_info("%s MAC: pM\n", __func__, rndis->ethaddr);
You lost a % there - it should be "%s MAC: %pM\n", no ?

DRH
>>
>>         ret = gether_setup_name(c->cdev->gadget, rndis->ethaddr, "rndis");
>>         if (ret) {
>> @@ -654,9 +652,7 @@ static ssize_t rndis_ethaddr_show(struct device *dev,
>>  {
>>         struct ccg_usb_function *f = dev_get_drvdata(dev);
>>         struct rndis_function_config *rndis = f->config;
>> -       return sprintf(buf, "%02x:%02x:%02x:%02x:%02x:%02x\n",
>> -               rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> -               rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> +       return sprintf(buf, "%pM\n", rndis->ethaddr);
>>  }
>>
>>  static ssize_t rndis_ethaddr_store(struct device *dev,
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/