linux-kernel - Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd2edLv_Tc8w-BXdKe3yjDVdm59-=_aQC8fJk-wmXf_6g@mail.gmail.com>
Date:	Fri, 6 Jul 2012 18:57:37 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Daniel Hazelton <dshadowwolf@...il.com>
Cc:	Kyungmin Park <kmpark@...radead.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

On Fri, Jul 6, 2012 at 6:54 PM, Daniel Hazelton <dshadowwolf@...il.com> wrote:
>>> --- a/drivers/staging/ccg/ccg.c
>>> +++ b/drivers/staging/ccg/ccg.c
>>> @@ -564,9 +564,7 @@ static int rndis_function_bind_config(struct ccg_usb_function *f,
>>>                 return -1;
>>>         }
>>>
>>> -       pr_info("%s MAC: %02X:%02X:%02X:%02X:%02X:%02X\n", __func__,
>>> -               rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>>> -               rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>>> +       pr_info("%s MAC: pM\n", __func__, rndis->ethaddr);
> You lost a % there - it should be "%s MAC: %pM\n", no ?
Thanks, I noticed this already. Patch v2 was sent recently.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/