linux-kernel - Re: [PATCH v3 0/6] Port Tegra to generic clk framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FF70F16.50205@wwwdotorg.org>
Date:	Fri, 06 Jul 2012 10:15:18 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Prashant Gaikwad <pgaikwad@...dia.com>
CC:	"mturquette@...com" <mturquette@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"olof@...om.net" <olof@...om.net>,
	Peter De Schrijver <pdeschrijver@...dia.com>
Subject: Re: [PATCH v3 0/6] Port Tegra to generic clk framework

On 07/06/2012 08:35 AM, Prashant Gaikwad wrote:
> On Friday 06 July 2012 12:19 AM, Stephen Warren wrote:
>> On 07/05/2012 03:55 AM, Prashant Gaikwad wrote:
>>> This patch set ports Tegra clock code to generic clock framework.
> <snip>
>> (The one slight difference between the 2 branches I tested is that AC100
>> and Trimslice booted using DT passed in next-20120705 but failed only in
>> Tegra's for-next. Otherwise, all results were identical)
>>
>> I'll try to investigate what the issues are since I imagine you don't
>> have access to these boards. But, I probably won't be able to fix this
>> until I return from vacation.
> 
> Stephen,
> 
> Can you please try removing "late_initcall(clk_disable_unused);" from
> drivers/clk/clk.c?
> It will keep unused clocks enabled. If it works then there should not be
> any regression in this patch series but need to enable some board
> specific clock.

On Whistler using next-20120705, that did help a bit; the board actually
boots to the login prompt in the usual amount of time rather than
hanging before even detecting the root filesystem.

However, there is obviously still some problem with I2C accesses, since
neither the pca953x nor wm8753 drivers are able to communicate with
their devices.

Re: the DT-vs-non-DT differences, it's most likely because only parts of
the clock initialization table are common (in common.c) and parts are in
board-${boardname}.c (for non-DT) or board-dt-tegra*.c (for DT). I'm
looking forward to when we can just put all the clock setup in the
board-specific .dts files:-)

I'll investigate more later (where most later might mostly be in 2 weeks
after I return from vacation)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/