linux-kernel - [RFC] SCSI: drivers: Remove unnecessary assignment of scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 8 Jul 2012 16:35:03 -0700
From:	Muthu Kumar <muthu.lkml@...il.com>
To:	Jej B <James.Bottomley@...senpartnership.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-kernel@...r.kernel.org,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: [RFC] SCSI: drivers: Remove unnecessary assignment of scsi_done in
 driver queuecommand

[ CCing signed-off, acked-by of original patch - let me know if anyone
else needs to be added ]

Jeff, James,

In the following commit:
----------
commit f281233d3eba15fb225d21ae2e228fd4553d824a
Author: Jeff Garzik <jeff@...zik.org>
Date:   Tue Nov 16 02:10:29 2010 -0500

    SCSI host lock push-down
---------

queuecommand syntax is changed to no longer passing done() routine as
parameter. Instead, in scsi_dispatch_command and scsi_send_eh_cmnd,
scsi_cmd->scsi_done is set to done() before calling the driver
specific queuecommand.
But all the drivers queuecommand routines still do the redundant assignment:

scsi_cmd->scsi_done = done

For example:

cciss_scsi_queue_command_lck():
..
cmd->scsi_done = done;    // save this for use by completion code
..

How about removing all such redundant assignments?

Regards,
Muthu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/