linux-kernel - Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdPZaOBiO8onji718m4caXjpAwoS9Fd1SKT5fM-hX8xxUbFZw@mail.gmail.com>
Date:	Sun, 8 Jul 2012 20:42:35 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	greg@...ah.com, sjakub@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH] asus_oled: Use pr_err(...) rather than
 printk(KERN_ERR ...)

git format-patch -s --subject-prfix="PATCH V2' will be better,


On Sun, Jul 8, 2012 at 2:55 PM, Toshiaki Yamane <yamanetoshi@...il.com> wrote:
> This change is inspired by checkpatch.
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com>
> ---
>  drivers/staging/asus_oled/asus_oled.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 510d796..f63c1d3 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -782,20 +782,20 @@ static int __init asus_oled_init(void)
>         oled_class = class_create(THIS_MODULE, ASUS_OLED_UNDERSCORE_NAME);
>
>         if (IS_ERR(oled_class)) {
> -               printk(KERN_ERR "Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
> +               pr_err("Error creating " ASUS_OLED_UNDERSCORE_NAME " class\n");
>                 return PTR_ERR(oled_class);
>         }
>
>         retval = class_create_file(oled_class, &class_attr_version.attr);
>         if (retval) {
> -               printk(KERN_ERR "Error creating class version file\n");
> +               pr_err("Error creating class version file\n");
>                 goto error;
>         }
>
>         retval = usb_register(&oled_driver);
>
>         if (retval) {
> -               printk(KERN_ERR "usb_register failed. Error number %d\n", retval);
> +               pr_err("usb_register failed. Error number %d\n", retval);
>                 goto error;
>         }
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/